fix: improve encoding detection and handling in detect_encoding and get_file_content
#2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi there! This PR was automatically generated by Autofix 🤖
This commit improves the robustness of encoding detection and handling, specifically addressing issues where encoding detection fails or results in unsupported encodings.
detect_encodingto handleNonecontent, log warnings for detection failures, validate encoding support, and provide better fallback mechanisms.get_file_contentto handle cases where decoded content is missing, log warnings for invalid encodings, and retry decoding with utf-8 on failure.If you have any questions or feedback for the Sentry team about this fix, please email autofix@sentry.io with the Run ID: 1.