Span.setData / Transaction.setData cause NullPointerException

[adinauer]

Integration

sentry

Java Version

any

Version

v7 + v8

Steps to Reproduce

• setData(null, "x")
• setData("x", null)
• setData(null, null)

all of these cause an NPE

Expected Result

just NoOp in that case (OTel also does that)

we can consider unsetting any current data with the same key, if a null value is set

Actual Result

NPE

[adinauer]

There's more places in the SDK where we do not accept null or even accept null and would cause NPE

• Contexts.set...
• SpanContext.setTag
• SpanContext.setData

there's likely more, we should search for usages of ConcurrentHashMap

[stefanosiano]

we can consider unsetting any current data with the same key, if a null value is set

Agree on this