-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add continuous profiling ProfileLifecycle #4202
Open
stefanosiano
wants to merge
12
commits into
feat/continuous-profiling-part1
Choose a base branch
from
feat/continuous-profiling-lifecycle
base: feat/continuous-profiling-part1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add continuous profiling ProfileLifecycle #4202
stefanosiano
wants to merge
12
commits into
feat/continuous-profiling-part1
from
feat/continuous-profiling-lifecycle
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() as experimental
…rofiling-wrapup # Conflicts: # CHANGELOG.md
…Default 0.0) sample rate is now evaluated inside AndroidContinuousProfiler and every time a session finishes
…ry.stopProfiler with Sentry.stopProfileSession
…ry.stopProfiler with Sentry.stopProfileSession
Sentry.startProfileSession() will work only in MANUAL mode Tracer start will start profiler only in TRACE mode Tracer and spans now attach profilerId only when sampled
|
Performance metrics 🚀
|
7 tasks
Base automatically changed from
feat/continuous-profiling-start-stop-rename
to
feat/continuous-profiling-part1
February 27, 2025 16:14
…rofiling-lifecycle # Conflicts: # CHANGELOG.md # sentry-android-core/api/sentry-android-core.api # sentry-android-core/src/main/java/io/sentry/android/core/AndroidContinuousProfiler.java # sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java # sentry-android-core/src/main/java/io/sentry/android/core/SentryPerformanceProvider.java # sentry-android-core/src/test/java/io/sentry/android/core/AndroidContinuousProfilerTest.kt # sentry-android-core/src/test/java/io/sentry/android/core/ManifestMetadataReaderTest.kt # sentry/api/sentry.api # sentry/src/main/java/io/sentry/ExperimentalOptions.java # sentry/src/main/java/io/sentry/IContinuousProfiler.java # sentry/src/main/java/io/sentry/NoOpContinuousProfiler.java # sentry/src/main/java/io/sentry/Scopes.java # sentry/src/main/java/io/sentry/SentryOptions.java # sentry/src/main/java/io/sentry/TracesSampler.java # sentry/src/test/java/io/sentry/NoOpContinuousProfilerTest.kt # sentry/src/test/java/io/sentry/ScopesTest.kt # sentry/src/test/java/io/sentry/SentryOptionsTest.kt # sentry/src/test/java/io/sentry/SentryTest.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Added ProfileLifecycle
Sentry.startProfileSession() will work only in MANUAL mode
Tracer start will start profiler only in TRACE mode
Tracer and spans now attach profilerId only when sampled
#skip-changelog
💡 Motivation and Context
We are adding profile lifecycle (
manual
|trace
), as per docs💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps