Fix Ensure app start type is set, even when ActivityLifecycleIntegration is not running

[markushi]

Fix Ensure app start type is set, even when ActivityLifecycleIntegration is not running or init is deferred.

Fixes getsentry/sentry-react-native#4598

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	404.83 ms	479.76 ms	74.93 ms
Size	1.70 MiB	2.36 MiB	671.82 KiB

Previous results on branch: markushi/fix/determine-app-start-type-via-content-provider

Startup times

Revision	Plain	With Sentry	Diff
ab6e139	393.55 ms	447.32 ms	53.77 ms
904a89c	322.18 ms	410.63 ms	88.45 ms
45c7ce0	358.77 ms	391.41 ms	32.64 ms
71b4c74	374.74 ms	407.65 ms	32.91 ms
48f18b6	373.96 ms	402.54 ms	28.58 ms
43531dd	428.61 ms	465.58 ms	36.97 ms

App size

Revision	Plain	With Sentry	Diff
ab6e139	1.70 MiB	2.36 MiB	671.71 KiB
904a89c	1.70 MiB	2.36 MiB	671.74 KiB
45c7ce0	1.70 MiB	2.36 MiB	672.38 KiB
71b4c74	1.70 MiB	2.36 MiB	671.82 KiB
48f18b6	1.70 MiB	2.36 MiB	672.40 KiB
43531dd	1.70 MiB	2.36 MiB	672.39 KiB

[stefanosiano]

Suggested change

	/**
	* @param hasBundle true if the activity onCreate had a non-null bundle
	* @param lastKnownStart in case the app start is too long, resets the app start timestamp to this
	* value
	*/
	public void updateAppStartType(final boolean hasBundle, final long lastKnownStart) {
	/**
	* @param hasBundle true if the activity onCreate had a non-null bundle
	* @param startUptimeMillis in case the app start is too long, resets the app start timestamp to this
	* value, retrieved via System.uptimeMillis()
	*/
	public void updateAppStartType(final boolean hasBundle, final long startUptimeMillis) {

Just make it clear we want a time from System.uptimeMillis()

[stefanosiano]

Good!
Can you also add the activity configuration check in the ActivityLifecycleIntegration, so that rotating the device doesn't count as warm start?

[stefanosiano]

there are a few things to adjust

[stefanosiano]

this is a behavioural change, as we were not doing it on API < 24, while now we would. I'd keep the previous check that returns early

[markushi]

Yes, that's on purpose - otherwise we would need to duplicate half of the logic within AppStartMetrics again, app start type, foreground importance, etc..

[krystofwoldrich]

@stefanosiano @markushi, let me and @denrase know if we should try this again with RN and Flutter before merging since there have been many changes since the initial draft.

[denrase]

@krystofwoldrich I'll test again and report back.

[denrase]

@markushi @krystofwoldrich So i was not able to verify this, now we bail out earlier, as the data suggests the app is not started in foreground. Also could not see in the debugger that the relevant code-paths in SentryPerformanceProvider.java were called.

[stefanosiano]

@denrase @krystofwoldrich can you try now?

[denrase]

@stefanosiano Worked, now cold start is even detected when i'm in debug mode. 👍

[krystofwoldrich]

I'm testing it with RN right now.

[krystofwoldrich]

Cold app start is correctly detected. But I struggle to get warm app start.