Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Continuous Profiling isStartProfilerOnAppStart option #4226

Open
wants to merge 3 commits into
base: feat/continuous-profiling-lifecycle
Choose a base branch
from

Conversation

stefanosiano
Copy link
Member

📜 Description

added isStartProfilerOnAppStart

#skip-changelog

💡 Motivation and Context

We are adding isStartProfilerOnAppStart, as per docs

💚 How did you test it?

Unit tests

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review March 4, 2025 12:21
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d72b09f

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 409.75 ms 479.36 ms 69.61 ms
Size 1.65 MiB 2.32 MiB 682.91 KiB

Baseline results on branch: feat/continuous-profiling-lifecycle

Startup times

Revision Plain With Sentry Diff
ce5dadf 401.65 ms 423.90 ms 22.24 ms
a8b1c40 355.38 ms 432.10 ms 76.72 ms

App size

Revision Plain With Sentry Diff
ce5dadf 1.65 MiB 2.32 MiB 682.68 KiB
a8b1c40 1.65 MiB 2.32 MiB 682.65 KiB

Previous results on branch: feat/continuous-profiling-app-start-option

Startup times

Revision Plain With Sentry Diff
783a2d2 388.38 ms 502.72 ms 114.34 ms

App size

Revision Plain With Sentry Diff
783a2d2 1.65 MiB 2.32 MiB 682.84 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant