Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekiq 8.0.0 beta #2569

Open
frederikspang opened this issue Feb 27, 2025 · 1 comment · May be fixed by #2570
Open

Sidekiq 8.0.0 beta #2569

frederikspang opened this issue Feb 27, 2025 · 1 comment · May be fixed by #2570
Assignees

Comments

@frederikspang
Copy link
Contributor

Describe the idea
Sidekiq 8 is on it's way, changing how created_at (et.al) are stored. This needs to be supported in sentry-Sidekiq queue instrumentation.

Why do you think it's beneficial to most of the users
To avoid faulty timings in Queues page.

Possible implementation
Look at type of created_at, as it's changing from float to int - Or branch into Sidekiq-version >= 8

See also:
https://github.com/sidekiq/sidekiq/blob/main/Changes.md#head--main

WARNING The created_at, enqueued_at, failed_at and retried_at attributes are now stored as epoch milliseconds, rather than epoch floats. This is meant to avoid precision issues with JSON and JavaScript's 53-bit Floats. Example: "created_at" => 1234567890.123456 -> "created_at" => 1234567890123.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Feb 27, 2025
@solnic solnic self-assigned this Feb 28, 2025
@solnic
Copy link
Collaborator

solnic commented Feb 28, 2025

Thanks for reporting this. I'll look into this.

@solnic solnic linked a pull request Feb 28, 2025 that will close this issue
@solnic solnic linked a pull request Feb 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants