Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[raven] use File.open in LineCache #2571

Merged
merged 1 commit into from
Mar 6, 2025
Merged

[raven] use File.open in LineCache #2571

merged 1 commit into from
Mar 6, 2025

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Mar 4, 2025 •
edited
Loading

Same as #2566 but for raven 🐦‍⬛

#skip-changelog

@solnic solnic force-pushed the solnic/code-scanning-alert-1-fix branch from a541340 to 2b50261 Compare March 4, 2025 14:15
@solnic solnic marked this pull request as ready for review March 4, 2025 15:05
@solnic solnic requested review from st0012 and sl0thentr0py March 4, 2025 15:05
sl0thentr0py
sl0thentr0py approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we actually never release raven, but it's fine to merge this in to silence the security warning

from next major I will simply move out the code from this repo completely and archive the raven code

@st0012
Copy link
Collaborator

st0012 commented Mar 6, 2025

I’d like to see sentry-raven gets removed too 👍

@solnic solnic force-pushed the solnic/code-scanning-alert-1-fix branch 3 times, most recently from 79b439d to 0e0880c Compare March 6, 2025 11:08
@solnic solnic merged commit f11a7aa into master Mar 6, 2025
154 of 155 checks passed
@solnic solnic deleted the solnic/code-scanning-alert-1-fix branch March 6, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py

@st0012 st0012

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@solnic @st0012 @sl0thentr0py