-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to monorepo #369
migrate to monorepo #369
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
It must be in the same directory as pnpm-workspace.yaml
Before: $ license_finder LicenseFinder::NPM: is active for '(snip)/giselles-ai/giselle' LicenseFinder::PNPM: is active for '(snip)/giselles-ai/giselle' All dependencies are approved for use After: $ license_finder LicenseFinder::PNPM: is active for '(snip)/giselles-ai/giselle' All dependencies are approved for use
Fix license_finder failure on `hello-monorepo` branch
@toyamarinyon The dependency_review job fails because of actions/dependency-review-action#867. It is not a required status and should be ignored. https://github.com/giselles-ai/giselle/actions/runs/13362487288?pr=369
|
I've checked following scenarios are worked:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙆♂️
move
studio.giselles.ai
application code from root directory toapps/studio.giselles.ai
.