Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to monorepo #369

Merged
merged 6 commits into from
Feb 17, 2025
Merged

migrate to monorepo #369

merged 6 commits into from
Feb 17, 2025

Conversation

toyamarinyon
Copy link
Contributor

@toyamarinyon toyamarinyon commented Feb 17, 2025

move studio.giselles.ai application code from root directory to apps/studio.giselles.ai.

Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giselle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 4:00am
monorepo-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 4:00am

masutaka and others added 4 commits February 17, 2025 12:41
It must be in the same directory as pnpm-workspace.yaml
Before:
$ license_finder
LicenseFinder::NPM: is active for '(snip)/giselles-ai/giselle'
LicenseFinder::PNPM: is active for '(snip)/giselles-ai/giselle'

All dependencies are approved for use

After:
$ license_finder
LicenseFinder::PNPM: is active for '(snip)/giselles-ai/giselle'

All dependencies are approved for use
Fix license_finder failure on `hello-monorepo` branch
@masutaka
Copy link
Member

@toyamarinyon The dependency_review job fails because of actions/dependency-review-action#867. It is not a required status and should be ignored.

https://github.com/giselles-ai/giselle/actions/runs/13362487288?pr=369

$GITHUB_STEP_SUMMARY upload aborted, supports content up to a size of 1024k, got 1094k. For more information see: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#adding-a-markdown-summary

@toyamarinyon
Copy link
Contributor Author

I've checked following scenarios are worked:

  • Can create accounts in post-monorepo migration environment
  • Can login in post-monorepo migration environment
  • Can create agents in post-monorepo migration environment
  • Can place, connect, and generate nodes in post-monorepo migration environment
  • Previously created agents work in post-monorepo migration environment

Copy link
Member

@shige shige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚝

Copy link
Contributor

@satococoa satococoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂️

@toyamarinyon toyamarinyon merged commit af71dfc into main Feb 17, 2025
9 of 10 checks passed
@toyamarinyon toyamarinyon deleted the hello-monorepo branch February 17, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants