Use embedded actions extractor only for old CLI versions
#2788
+23
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR updates the logic to use the embedded actions extractor only for CLI versions prior to 2.20.6.
- Updates conditional logic based on the CodeQL version
- Includes detailed inline comments explaining the rationale for maintaining the embedded extractor for older versions
Reviewed Changes
| File | Description |
|---|---|
| src/codeql.ts | Modified conditional check to use the embedded extractor only for pre-2.20.6 versions |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
dbartol
force-pushed
the
dbartol/use-real-actions-extractor
branch
from
bd44fca to
85e30fe
Compare
angelapwen
previously approved these changes
Feb 27, 2025
For this change, there should be no user-visible impact, so I'm skipping the change note. When we do finally remove the embedded extractor entirely, I'll add a change note, although we don't expect any users to actually notice the breaking change. |
|
Sounds good to me!! 🚢 |
angelapwen
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to remove the embedded
actionsextractor, we discovered that the extractor in the actual CLI download is missing the execute bit on its scripts. That's fixed in 2.20.6, so I've changed the Action to only use the embedded extractor for pre-2.20.6 versions.Merge / deployment checklist