Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not artificially restrict the set of supported languages #779

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+208 −129
Draft

Do not artificially restrict the set of supported languages #779

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a8725d
let the codeql env decide the supported languages
esbena Oct 14, 2021
3847055
fix TypeScript NPE type warning
esbena Oct 14, 2021
91e3c85
add test
esbena Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix TypeScript NPE type warning
  • Loading branch information
@esbena
esbena committed Oct 25, 2021
commit 3847055a30388dbb66d5cfbdee60c00de1df8e3e
2 changes: 1 addition & 1 deletion src/config-utils.ts
View file
Original file line number Diff line number Diff line change
@@ -1174,7 +1174,7 @@ function shouldCombinePacks(packsInput?: string): boolean {
function combinePacks(packs1: Packs, packs2: Packs): Packs {
const packs = {};
for (const lang of Object.keys(packs1)) {
packs[lang] = packs1[lang].concat(packs2[lang] || []);
packs[lang] = packs1[lang]?.concat(packs2[lang] || []);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is what we want to do in order to ensure we never set packs[lang] to undefined.

Suggested change
packs[lang] = packs1[lang]?.concat(packs2[lang] || []);
packs[lang] = (packs1[lang] || []).concat(packs2[lang] || []);

}
for (const lang of Object.keys(packs2)) {
if (!packs[lang]) {