Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGTM.com - similar-function false positive? #2357

Open
dgw opened this issue Nov 16, 2019 · 0 comments
Open

LGTM.com - similar-function false positive? #2357

dgw opened this issue Nov 16, 2019 · 0 comments
Labels
false-positive Python

Comments

@dgw
Copy link

dgw commented Nov 16, 2019

Description of the false positive

These are very similar decorator functions, yes. But they can't really be refactored to share code due to how decorators work. (Or if they can, I'm not experienced enough in Python to know how.)

URL to the alert on the project page on LGTM.com

First in pair: https://lgtm.com/projects/g/sopel-irc/sopel/snapshot/182754526ebc14910cf4082e664542155d4460d9/files/sopel/module.py?sort=name&dir=ASC&mode=heatmap#x2e1276a8323e6dba:1
Second in pair: https://lgtm.com/projects/g/sopel-irc/sopel/snapshot/182754526ebc14910cf4082e664542155d4460d9/files/sopel/module.py?sort=name&dir=ASC&mode=heatmap#x5ac5294b0292d05f:1
@dgw dgw changed the title LGTM.com - false positive LGTM.com - similar-function false positive? Nov 16, 2019
@tausbn tausbn self-assigned this Nov 19, 2019
@tausbn tausbn added the Python label Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false-positive Python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgw @tausbn