Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGTM.com - false positive - no override of __eq__ #2408

Open
tomato42 opened this issue Nov 21, 2019 · 0 comments
Open

LGTM.com - false positive - no override of __eq__ #2408

tomato42 opened this issue Nov 21, 2019 · 0 comments
Labels
false-positive Python

Comments

@tomato42
Copy link

Description of the false positive

https://lgtm.com/projects/g/tomato42/tlslite-ng/snapshot/3a213568fa89ebb0c9041b9d7dae5580f6d05afc/files/tlslite/messages.py#xb5046a97293d00a3:1

The alert is a false positive because the messages use byte serialisation of themselves to check for equality with other objects and the serialisation method (write()) was updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false-positive Python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomato42 @tausbn