Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGTM.com - false positive: JS type of console.log variable incorrectly detected #2666

Open
ljharb opened this issue Jan 21, 2020 · 0 comments

Comments

@ljharb
Copy link

ljharb commented Jan 21, 2020

Description of the false positive

The variable is defined with var originalLog = console.log;. typeof console.log is function or object (an exotic implementation object that is callable) depending on the browser.

The warning says it has type "boolean, date, number, object, regular expression or string" - there's a few problems with this:

  1. Dates and RegExps are not a type in JS (and if they are, Arrays, Maps, Sets, Promises, etc are too)
  2. this is also missing symbol and bigint
  3. Given the possible exotic type of console.log as object - a callable object - this is not actually a valid warning.

URL to the alert on the project page on LGTM.com

https://lgtm.com/projects/g/substack/testling/snapshot/8d454f8d81bb0e84b06879a4506e530b8bdc87ac/files/browser/prelude.js?sort=name&dir=ASC&mode=heatmap#x1b735cba61dcb9a1:1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants