Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported language codes #10480

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

rvermeulen
Copy link
Contributor

Add support for the languages Ruby and Swift based on the language codes used in the queries.

Add support for the languages Ruby and Swift based on the language codes used in the queries.
@rvermeulen rvermeulen requested a review from a team as a code owner September 19, 2022 21:42
Copy link
Collaborator

@sj sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is documentation for query developers, and it's good to include swift and rb in that list from that point of view. I'm a little worried that the current wording could confuse customers or sales reps who accidentally end up in the wrong place looking for CodeQL language support.

Could we perhaps update the wording of the paragraph above the list? For example, replace this:

[...] forward slash. The following language codes are supported:
 - C and C++: cpp
 - ...

With:

[...] forward slash. The following language codes are currently in use for CodeQL query development:
 - C and C++: cpp
 - ...
 - Ruby: rb
 - Swift: swift

For a full list of currently supported CodeQL languages (and the level of coverage), 
please see [the CodeQL documentation](https://codeql.github.com/docs/).

@sj
Copy link
Collaborator

sj commented Sep 23, 2022

Side-note: should we include Kotlin in that list, e.g. as:
- Java and Kotlin: java?

Add suggestions from @sj to prevent confusion around language support
Add Kotlin to the list of supported languages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants