Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Add more documentation in regards to SSRF #18855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

Python: Add more documentation in regards to SSRF #18855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add more choices to SSRF remediation
  • Loading branch information
@Kwstubbs
Kwstubbs committed Feb 25, 2025
commit 04476ca5f4a64d2348d82d5579e7c7d8ac5bd166
7 changes: 5 additions & 2 deletions python/ql/src/Security/CWE-918/ServerSideRequestForgery-end.inc.qhelp
View file
Original file line number Diff line number Diff line change
@@ -5,8 +5,11 @@
<recommendation>

<p>To guard against SSRF attacks you should avoid putting user-provided input directly
into a request URL. Instead, either maintain a list of authorized URLs on the server and choose
from that list based on the input provided, or perform proper validation of the input.
into a request URL. On the application level, maintain a list of authorized URLs on the server and choose
from that list based on the input provided. If that is not possible, one should verify the IP address for all user-controlled
requests to ensure they are not private. This requires saving the verified IP address of each domain,
then utilizing a custom HTTP adapter to ensure that future requests to that domain use the verified IP address.
On the network level, you can segment the vulnerable application into its own LAN or block access to specific devices.
</p>

</recommendation>