C#: Add cs/call-to-object-tostring to the CCR query suite. #18866
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
…he only flag set is Standalone.
michaelnebel
force-pushed
the
csharp/ccr-call-to-object-tostring
branch
from
5e6e4be to
562071f
Compare
| string y1 = x1.Prop; | ||
|
|
||
| var x2 = new C(); // Has type `var` as this overrides the implicitly typed keyword `var`. | ||
| var y2 = x2.Prop; // Unknown type as `x2` har type `var`. |
There was a problem hiding this comment.
Minor: typo in har vs has.
There was a problem hiding this comment.
Thanks for looking into the changes! I put the branch in draft mode again, as it is being used for experiments with extractor changes as well.
It turns out that both the roslyn and mono repo suffers from "broken" types.
There was a problem hiding this comment.
So no need to review yet :-D (will re-request a review when all the back and forth stuff has been handled).
| return false; | ||
| } | ||
| // (1) public class { ... } is a broken type and doesn't have a name. | ||
| // (2) public class var { ... } is a an allowed type, but it overrides the var keyword for all uses. |
There was a problem hiding this comment.
Minor: typo in is a an allowed
| if (IsBrokenType(Symbol)) | ||
| return Kinds.TypeKind.UNKNOWN; |
There was a problem hiding this comment.
Would the symbol for C show up as a broken one in the below?
class C {
int i;
}
class C {
int j;
}
There was a problem hiding this comment.
No.
The "only" types that are categorised broken are either a type named var or if there is not any name supplied (syntax error).
We could make it more advanced if needs be. Right now I am just looking in the issues we can see from results to cs/call-to-object-tostring.
michaelnebel
force-pushed
the
csharp/ccr-call-to-object-tostring
branch
from
562071f to
f9f3e99
Compare
No description provided.