Go: Slightly adjust some location info to match locations that are in the database #18868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR updates the change notes to reflect slight adjustments to location information in the Go library, aligning it with the location data in the database.
- Updated change notes for several classes.
- Adjusted location details to simplify the usage of
Location getLocation()predicates.
Reviewed Changes
| File | Description |
|---|---|
| go/ql/lib/change-notes/2025-02-26-location-info-changed.md | Updated change notes with adjusted location information |
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
smowton
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes locations in the Go library more consistent with other language libraries. It will also allow us to move to using
Location getLocation()member predicates more, without theLocationclass being too complicated.