Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ssa: Update qltests including consistency checks #18869

Merged
merged 12 commits into from
Mar 5, 2025
Merged
Prev Previous commit
Next Next commit
SSA: Change a few DefinitionExt uses that are actually just Definitions.
  • Loading branch information
aschackmull committed Mar 4, 2025
commit 39bba7f5c2cc5440c8cd9c30b59948ea30afc1c9
6 changes: 3 additions & 3 deletions shared/ssa/codeql/ssa/Ssa.qll
Original file line number Diff line number Diff line change
@@ -1794,7 +1794,7 @@ module Make<LocationSig Location, InputSig<Location> Input> {
// Flow from parameter into entry definition
DfInput::ssaDefInitializesParam(def, nodeFrom.(ParameterNode).getParameter())
) and
nodeTo.(SsaDefinitionExtNodeImpl).getDefExt() = def and
nodeTo.(SsaDefinitionNode).getDefinition() = def and
isUseStep = false
or
// Flow from definition/read to next read
@@ -1810,7 +1810,7 @@ module Make<LocationSig Location, InputSig<Location> Input> {
AdjacentSsaRefs::adjacentRefRead(bb1, i1, bb2, i2, v) and
exists(UncertainWriteDefinition def2 |
DfInput::allowFlowIntoUncertainDef(def2) and
nodeTo.(SsaDefinitionExtNodeImpl).getDefExt() = def2 and
nodeTo.(SsaDefinitionNode).getDefinition() = def2 and
def2.definesAt(v, bb2, i2)
)
)
@@ -1841,7 +1841,7 @@ module Make<LocationSig Location, InputSig<Location> Input> {
// Flow from parameter into entry definition
DfInput::ssaDefInitializesParam(def, nodeFrom.(ParameterNode).getParameter())
) and
nodeTo.(SsaDefinitionExtNodeImpl).getDefExt() = def
nodeTo.(SsaDefinitionNode).getDefinition() = def
or
// Flow from SSA definition to read
nodeFrom.(SsaDefinitionExtNodeImpl).getDefExt() = def and