Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Simplify interpretOutput #18874

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Java: Simplify interpretOutput #18874

merged 1 commit into from
Feb 27, 2025

Conversation

alexet
Copy link
Contributor

@alexet alexet commented Feb 26, 2025

I am pretty sure that this is equivalent and avoids weird join ordering issues as both disjuncts now use the same variables. Otherwise we need n and ast bound to do the disjunction but that is a CP externally. Currently it is Ok as it seems these cases are always empty before the CP by the c = "Parameter" or c = "" and we know the input data is static but the CP is there if someone ever writes one of those cases (or in my case we change the optimiser to be less aggressive about pushing equalities after join ordering)

I feel it might be possible to write QL4QL query for this case noting that the fact that n and ast are unused in the disjunct is what makes the substitution valid.

@alexet alexet requested review from hvitved and Copilot February 26, 2025 18:50
@alexet alexet requested a review from a team as a code owner February 26, 2025 18:50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@github-actions github-actions bot added the Java label Feb 26, 2025
@owen-mc
Copy link
Contributor

owen-mc commented Feb 26, 2025

Fwiw I made the node.asNode() change in the go version of this function in this commit, at the same time as adding some binding pragmas. It hasn't caused any problems that I'm aware of. I just checked the same function in other languages and didn't find the same node.asNode() issue - we must have copied it from the java library to the go library at some point.

@hvitved hvitved requested review from aschackmull and removed request for hvitved February 27, 2025 08:45
@alexet alexet added the no-change-note-required This PR does not need a change note label Feb 27, 2025
@alexet alexet merged commit f7d95e4 into main Feb 27, 2025
14 of 15 checks passed
@alexet alexet deleted the alexet/simplify-interpretoutput branch February 27, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants