Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am pretty sure that this is equivalent and avoids weird join ordering issues as both disjuncts now use the same variables. Otherwise we need
n
andast
bound to do the disjunction but that is a CP externally. Currently it is Ok as it seems these cases are always empty before the CP by thec = "Parameter" or c = ""
and we know the input data is static but the CP is there if someone ever writes one of those cases (or in my case we change the optimiser to be less aggressive about pushing equalities after join ordering)I feel it might be possible to write QL4QL query for this case noting that the fact that
n
andast
are unused in the disjunct is what makes the substitution valid.