Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: fix dataflow test failure by pinning the toolchain version #18881

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

redsun82
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Feb 27, 2025
@@ -100,10 +112,12 @@ nodes
| main.rs:87:18:87:32 | { ... } | semmle.label | { ... } |
subpaths
testFailures
| main.rs:59:10:59:11 | s2 | Fixed missing result: hasTaintFlow=22 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the matching comment should be updated :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opted for pinning the toolchain version to 1.84, but we can revisit when we upgrade to 1.85

@redsun82 redsun82 force-pushed the redsun82/rust-fix-test branch from d0151ae to beeb417 Compare February 27, 2025 14:39
@redsun82 redsun82 changed the title Rust: fix dataflow test failure Rust: fix dataflow test failure by pinning the toolchain version Feb 27, 2025
@redsun82 redsun82 marked this pull request as ready for review February 27, 2025 14:43
@redsun82 redsun82 added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Feb 27, 2025
@redsun82 redsun82 merged commit 3c7fe26 into main Feb 28, 2025
11 of 12 checks passed
@redsun82 redsun82 deleted the redsun82/rust-fix-test branch February 28, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on internal PR This PR should only be merged in sync with an internal Semmle PR Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants