Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: handle lock state check stored in variable for java/unreleased-lock #18900

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

jcogs33
Copy link
Contributor

@jcogs33 jcogs33 commented Feb 28, 2025

This PR adjusts the java/unreleased-lock query so that it no longer reports alerts in cases where a boolean variable is used to track lock state.

@github-actions github-actions bot added the Java label Feb 28, 2025
@jcogs33 jcogs33 force-pushed the jcogs33/java/unreleased-lock-fp branch from 5882526 to fbf7513 Compare March 2, 2025 22:01
@jcogs33 jcogs33 changed the title [DRAFT] Java: handle lock state check stored in variable for java/unreleased-lock Java: handle lock state check stored in variable for java/unreleased-lock Mar 2, 2025
@jcogs33
Copy link
Contributor Author

jcogs33 commented Mar 3, 2025

Alert changes in DCA look reasonable to me.
The bad rows in DCA look flaky, so I don't think they are related to the change on this PR.

@jcogs33 jcogs33 marked this pull request as ready for review March 3, 2025 21:29
@jcogs33 jcogs33 requested a review from a team as a code owner March 3, 2025 21:29
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcogs33 jcogs33 merged commit c22b05a into github:main Mar 4, 2025
16 checks passed
@jcogs33 jcogs33 deleted the jcogs33/java/unreleased-lock-fp branch March 4, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants