Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ query to extract the number of errors due to include file resolution failure #18914

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

esteffin
Copy link
Contributor

@esteffin esteffin commented Mar 3, 2025

This PR adds a query to get metrics to evaluate the include resolution status in C++ BMN.

It will be added to DCA as an uninterpreted query.

@Copilot Copilot bot review requested due to automatic review settings March 3, 2025 18:37
@esteffin esteffin requested a review from a team as a code owner March 3, 2025 18:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@github-actions github-actions bot added the C++ label Mar 3, 2025
@esteffin esteffin force-pushed the esteffin/bmn-include-file-resolution-statistics branch from 2d3e3aa to d5e8a24 Compare March 3, 2025 18:57
@esteffin esteffin added the no-change-note-required This PR does not need a change note label Mar 3, 2025
@esteffin esteffin force-pushed the esteffin/bmn-include-file-resolution-statistics branch from d5e8a24 to 8b56c60 Compare March 3, 2025 19:19
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial questions.

Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@esteffin esteffin force-pushed the esteffin/bmn-include-file-resolution-statistics branch from 7852fe7 to aa5b89f Compare March 4, 2025 13:48
@esteffin esteffin requested review from a team as code owners March 4, 2025 13:48
@github-actions github-actions bot added Rust Pull requests that update Rust code Swift DataFlow Library Actions Analysis of GitHub Actions labels Mar 4, 2025
@esteffin esteffin force-pushed the esteffin/bmn-include-file-resolution-statistics branch from aa5b89f to 1efff28 Compare March 4, 2025 13:50
@jketema jketema removed request for a team March 4, 2025 13:51
@esteffin esteffin force-pushed the esteffin/bmn-include-file-resolution-statistics branch from 1efff28 to e230166 Compare March 4, 2025 13:57
@jketema jketema merged commit 45c4f3f into main Mar 4, 2025
13 checks passed
@jketema jketema deleted the esteffin/bmn-include-file-resolution-statistics branch March 4, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants