Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disjunction mentions
request
on one side andrequestNode
on the other. This means that the disjunction can't go first and the call the the charpred must be done first. Due to ainline_late bindingset[...]
call inside the inlinednew.getReturn(_)
we can't start with that inside the disjunct and we therefore must choose a CP. Luckily in most databases the CP ends up small.This is not important at all for the new join orderer as better heuristics now means it picks the correct CP but I felt it was better to avoid it in case someone creates a project with many
Net::HTTP.new(...).get(...)
calls.