Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: Avoid a forced CP. #18927

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Ruby: Avoid a forced CP. #18927

wants to merge 1 commit into from

Conversation

alexet
Copy link
Contributor

@alexet alexet commented Mar 4, 2025

The disjunction mentions request on one side and requestNode on the other. This means that the disjunction can't go first and the call the the charpred must be done first. Due to a inline_late bindingset[...] call inside the inlined new.getReturn(_) we can't start with that inside the disjunct and we therefore must choose a CP. Luckily in most databases the CP ends up small.

This is not important at all for the new join orderer as better heuristics now means it picks the correct CP but I felt it was better to avoid it in case someone creates a project with many Net::HTTP.new(...).get(...) calls.

@github-actions github-actions bot added the Ruby label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant