Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contradictory information regarding CNAME and GitHub Pages and Actions #36593

Closed
1 task done
climbTheStairs opened this issue Mar 3, 2025 · 5 comments · Fixed by #36610
Closed
1 task done

Contradictory information regarding CNAME and GitHub Pages and Actions #36593

climbTheStairs opened this issue Mar 3, 2025 · 5 comments · Fixed by #36610
Labels
content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review

Comments

@climbTheStairs
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/troubleshooting-custom-domains-and-github-pages#cname-errors
https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site#configuring-an-apex-domain

What part(s) of the article would you like to see updated?

In the first article:

If you are publishing from a custom GitHub Actions workflow, any CNAME file is ignored and is not required.

In the second one:

If you are publishing your site with a custom GitHub Actions workflow, no CNAME file is created, so you need to create one manually (containing only a line of text with your custom domain).

If I am publishing GitHub Pages with a custom GitHub Actions workflow, it is unclear whether I need to create a CNAME or not.

Additional information

No response

@climbTheStairs climbTheStairs added the content This issue or pull request belongs to the Docs Content team label Mar 3, 2025
Copy link

welcome bot commented Mar 3, 2025

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 3, 2025
@subatoi
Copy link
Contributor

subatoi commented Mar 3, 2025

@climbTheStairs Thanks for raising an issue—this is really better suited for GitHub Support but in this case, I think our docs could be clearer here, so apologies for the confusion it's caused. Can I just establish: are you trying to publish from a specific branch that's not the default branch?

@climbTheStairs
Copy link
Contributor Author

Is it even possible to publish from a specific branch if I'm publishing from a custom GitHub Actions workflow?

@subatoi subatoi added waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Mar 3, 2025
@subatoi
Copy link
Contributor

subatoi commented Mar 3, 2025

I haven't attempted that, but I was trying to establish what you were trying to do; I'll assume it wasn't that. I'll investigate the original question internally to try to get a definitive answer. Thanks!

@subatoi
Copy link
Contributor

subatoi commented Mar 4, 2025

@climbTheStairs Apologies for the confusion here—the first article is correct, and the second one needs to be updated. Would you like to open a PR to correct the wording in https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site#configuring-an-apex-domain?

We need to remove so you need to create one manually (containing only a line of text with your custom domain) and mention that the CNAME is not only not created, but not required.

@subatoi subatoi added more-information-needed More information is needed to complete review and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 4, 2025
@climbTheStairs climbTheStairs mentioned this issue Mar 4, 2025
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants