Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update about-githubs-ip-addresses.md #36586

Merged
merged 4 commits into from
Mar 3, 2025
Merged

Conversation

LinuxOnTheDesktop
Copy link
Contributor

I have corrected an ungrammatical use of 'however': that word is not a conjunction, and unclarity can result from using it as if it were a conjunction.

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff. [I have 'ticked' this, but it is not applicable.]
  • The changes in this PR meet the docs fundamentals that are required for all content. [Surely grammatical fixes are allowed.]
  • All CI checks are passing and the changes look good in the review environment. [Surely these checks - which have yet to be run - will pass.]

I have corrected an ungrammatical use of 'however': that word is not a conjunction, and unclarity can result from using it as if it were a conjunction.
Copy link

welcome bot commented Mar 2, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

github-actions bot commented Mar 2, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
authentication/keeping-your-account-and-data-secure/about-githubs-ip-addresses.md fpt
ghec
fpt
ghec

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 2, 2025
Copy link

@tr4200812 tr4200812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤒

Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LinuxOnTheDesktop Thanks for spotting that: I've changed this to the word "but" because that's the slightly better edit under the circumstances. I'll get this merged for you now—thanks for your interest in the GitHub Docs!

@subatoi subatoi added content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Mar 3, 2025
@subatoi subatoi enabled auto-merge March 3, 2025 08:28
@subatoi subatoi disabled auto-merge March 3, 2025 09:04
@subatoi subatoi added this pull request to the merge queue Mar 3, 2025
Merged via the queue into github:main with commit 24f76be Mar 3, 2025
42 checks passed
Copy link
Contributor

github-actions bot commented Mar 3, 2025

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@LinuxOnTheDesktop LinuxOnTheDesktop deleted the patch-1 branch March 3, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants