-
Notifications
You must be signed in to change notification settings - Fork 61.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update about-githubs-ip-addresses.md #36586
Conversation
I have corrected an ungrammatical use of 'however': that word is not a conjunction, and unclarity can result from using it as if it were a conjunction.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options:
A Hubber will need to deploy your changes internally to review. Table of review linksThe table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤒
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LinuxOnTheDesktop Thanks for spotting that: I've changed this to the word "but" because that's the slightly better edit under the circumstances. I'll get this merged for you now—thanks for your interest in the GitHub Docs!
content/authentication/keeping-your-account-and-data-secure/about-githubs-ip-addresses.md
Outdated
Show resolved
Hide resolved
…out-githubs-ip-addresses.md
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
I have corrected an ungrammatical use of 'however': that word is not a conjunction, and unclarity can result from using it as if it were a conjunction.
Why:
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: