Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITHUB_USER and GITHUB_PAT are no longer needed #172

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

robandpdx
Copy link
Collaborator

This pull request removes the requirement for GitHub user and personal access token (PAT) credentials from the project configuration and documentation. The most important changes include updates to the .env-sample file, the README.md file, and the app.js file.

@Copilot Copilot bot review requested due to automatic review settings February 25, 2025 19:49

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request removes the dependency on GitHub user credentials and PATs from the project configuration and documentation to simplify authentication.

  • Removed the auth object in app.js that passed GitHub credentials
  • Updated README.md by eliminating references and instructions for GITHUB_USER and GITHUB_PAT

Reviewed Changes

File Description
app.js Removed the unused auth object referencing GitHub credentials.
README.md Removed documentation and docker command references to GitHub credentials.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

app.js:1

  • Removal of the auth object appears intentional; please confirm that no other parts of the application rely on these credentials.
const auth = {

README.md:57

  • Ensure that all references to GITHUB_USER and GITHUB_PAT are removed from the documentation and that the configuration instructions are updated consistently.
-You will also need a user and PAT with admin permissions on the repos in order to merge bypassing checks and required approvals. These will be supplied to the app as the following env vars:

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

Copy link


=============================== Coverage summary ===============================
Statements   : 100% ( 149/149 )
Branches     : 100% ( 88/88 )
Functions    : 100% ( 27/27 )
Lines        : 100% ( 148/148 )
================================================================================

@robandpdx robandpdx merged commit 4e5111e into main Feb 25, 2025
5 checks passed
@robandpdx robandpdx deleted the remove-gh-user branch February 25, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant