Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema Inaccuracy] Security Schemes Missing #237

Open
philsturgeon opened this issue Mar 19, 2021 · 3 comments
Open

[Schema Inaccuracy] Security Schemes Missing #237

philsturgeon opened this issue Mar 19, 2021 · 3 comments
Labels
enhancement New feature or request P4

Comments

@philsturgeon
Copy link
Contributor

philsturgeon commented Mar 19, 2021

Schema Inaccuracy

GitHub REST API uses OAuth2 access tokens, and has some support for query string tokens (deprecated) and basic auth (hmmmm) which could be described in your OpenAPI.

Expected

    components:
      securitySchemes:
        BasicAuth:
          type: http
          scheme: basic

        OAuth2:
          type: oauth2
          flows:
            authorizationCode:
              authorizationUrl: https://example.com/oauth/authorize
              tokenUrl: https://example.com/oauth/token
              scopes:
                read: Grants read access
                write: Grants write access
                admin: Grants access to admin operations

Also this gave me the idea to make security schemes in OpenAPI, deprecateable thank you! OAI/OpenAPI-Specification#2506

@ahoglund
Copy link
Contributor

@philsturgeon - Thanks for opening this issue! I'll add it to our internal backlog for discussion with the team.

@bruce bruce added P4 enhancement New feature or request and removed inaccuracy labels Aug 4, 2021
@tomaszdurka
Copy link

I want to use Github api spec in an automated way. Is there possibility to add securitySchemes and security requirements for operations into the spec?

Thanks

@kmahorker
Copy link

Hi @shiftkey and @bearcherian 👋🏼

Any chance this could become a priority to be included?

Even securitySchemes described/noted in the readme could be very helpful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P4
Projects
None yet
Development

No branches or pull requests

5 participants