Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port view is empty #13377

Open
mikenikles opened this issue Sep 27, 2022 · 15 comments
Open

Port view is empty #13377

mikenikles opened this issue Sep 27, 2022 · 15 comments
Assignees
Labels
browser: firefox editor: code (browser) feature: ports meta: blocked in progress but blocked by upstream issues or missing data meta: never-stale This issue can never become stale team: IDE type: bug Something isn't working

Comments

@mikenikles
Copy link
Contributor

Bug description

The new default ports view appears empty.

Steps to reproduce

Start a workspace with the following ports defined in .gitpod.yml:

ports:
  - port: 3000
    onOpen: ignore
  - port: 3001
    onOpen: ignore
  - port: 3005
    onOpen: ignore
  - port: 3080
    onOpen: ignore
    visibility: public
  - port: 5001
    onOpen: ignore
  - port: 5432
    onOpen: ignore
  - port: 8000
    onOpen: ignore
  - port: 8001
    onOpen: ignore
  - port: 8020
    onOpen: ignore
  - port: 8030
    onOpen: ignore
  - port: 8040
    onOpen: ignore
  - port: 8080
    onOpen: ignore
  - port: 9090
    onOpen: ignore
  - port: 9323
    onOpen: ignore

Workspace affected

No response

Expected behavior

The ports view lists all ports.

Example repository

It happens for a private repo. If additional info is required beyond the ports configuration in .gitpod.yml as shared above, please let me know.

Anything else?

No response

@mustard-mh
Copy link
Contributor

mustard-mh commented Sep 28, 2022

I tested it https://github.com/mustard-mh/test/tree/hw/port-view with both stable and latest browser code, both worked. Could you try it on your side? Or provide more information like screenshots, logs, window log. 🙏 @mikenikles

@mikenikles
Copy link
Contributor Author

Thanks for testing, Huiwen. For your test repo, I do see the ports listed. I use stable VS Code in the browser.

Screenshot image

I sent the requested logs to the support email address.

@jeanp413
Copy link
Member

jeanp413 commented Oct 4, 2022

This is a firefox bug, workaround for now is reload the tab

@akosyakov akosyakov removed this from 🚀 IDE Team Oct 7, 2022
@akosyakov akosyakov added the meta: blocked in progress but blocked by upstream issues or missing data label Oct 7, 2022
@akosyakov
Copy link
Member

@jeanp413 Do we have an issue in upstream to link to?

@jeanp413
Copy link
Member

jeanp413 commented Oct 7, 2022

@jeanp413 Do we have an issue in upstream to link to?

Nope as I can't reproduce upstream with MS cdn, also workaround for this firefox bug is already there (empty script tag) and works with MS cdn

@MvRemmerden
Copy link

Having the same problem on Firefox, and can confirm that it works as expected on Chrome.

@akosyakov
Copy link
Member

We did some improvements to how we serve webviews last week and I'm having hard time to reproduce it now. @mikenikles @MvRemmerden Could you try again?

@mustard-mh @jeanp413 I rarely see stale start in Chrome today, so it loads very fast. I wonder why.

@jeanp413 jeanp413 removed this from 🚀 IDE Team Oct 17, 2022
@mikenikles
Copy link
Contributor Author

It disappeared completely today. It worked well yesterday.

image

@jeanp413
Copy link
Member

Maybe it got moved to another location or hidden accidentally, Could you run View: Focus on ports view, and if it's in another location right click on it's icon/header and select Reset location

@mikenikles
Copy link
Contributor Author

You're right, it moved to the left side below the Explorer. I didn't see Reset location, but could drag & drop it back in place. Odd that it changes without me making any changes. I'll keep an eye on it.

@mustard-mh
Copy link
Contributor

mustard-mh commented Oct 21, 2022

Hi @mikenikles 👋 , thanks for your awareness, we created a PR #14102 to fix default location of PortsView.

Changes are deployed in both stable and latest Browser Code in SaaS Gitpod now. 🙏

@stale
Copy link

stale bot commented Jan 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jan 21, 2023
@loujaybee loujaybee added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Feb 6, 2023
@scraly
Copy link

scraly commented Feb 7, 2023

Reproduced on Firefox browser. I created several workspaces, refresh/reload the page without any success.
I am using Firefox with GitPod since the begining and I have the problem only since yesterday...
FYI I don't have the trouble on Chrome.

@jeanp413
Copy link
Member

jeanp413 commented Feb 7, 2023

Thanks for reporting it, will release a fix later today 🙏

Upstream PR microsoft/vscode#173682

@jeanp413
Copy link
Member

jeanp413 commented Feb 7, 2023

@scraly I deployed vscode stable with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: firefox editor: code (browser) feature: ports meta: blocked in progress but blocked by upstream issues or missing data meta: never-stale This issue can never become stale team: IDE type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants