Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Integrate public API's into supervisor #15383

Open
3 of 9 tasks
akosyakov opened this issue Dec 16, 2022 · 1 comment
Open
3 of 9 tasks

Epic: Integrate public API's into supervisor #15383

akosyakov opened this issue Dec 16, 2022 · 1 comment
Assignees
Labels
component: supervisor feature: public-api Issues relating to Public API meta: never-stale This issue can never become stale team: IDE type: epic

Comments

@akosyakov
Copy link
Member

akosyakov commented Dec 16, 2022

Summary

Migrate supervisor from Server to Public API.

Context

Why we chose to migrate Supervisor to the new Public API? In order to validate Public API we started with #9757, but VS Code Desktop depends on SH installations which block migrations till Public API is reliable. VS Code as well does not have interesting use cases to validate usability and reliabiltiy of the API, i.e. pooling vs streaming, and does not generate enough traffic. We have also had incidents with supervisor working against Server API. We could not react promptly because we don't have any client observability [1], additionally jsonrpc library which we use on go client side has very verbose logging [2]. Because of all these reasons it looks sensible to migrate supervisor first:

  • it has a tricky use cases, like listening to workspace status updates to promptly update UI state
  • Used in each workspace and will generate enough traffic.
  • Easy to migrate since it is self contained in each installation.
  • Improves reliability by using client side grpc observability.
  • Improves security by giving us control of logging.

Value

  • Validate usability and reliability of Public API.
  • Improve reliability and security of connection between supervisor and Public APi.

Acceptance Criteria

  • Supervisor don't use Server API anymore, but completely relies on Public API.

Measurement

  • 99% of requests from supervisor to Public API should be successful. SLO

Remaining Work

Descoped / Nice to have

nit

@stale
Copy link

stale bot commented Jun 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 10, 2023
@mustard-mh mustard-mh added the meta: never-stale This issue can never become stale label Jun 27, 2023
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: supervisor feature: public-api Issues relating to Public API meta: never-stale This issue can never become stale team: IDE type: epic
Projects
Status: In Progress
Development

No branches or pull requests

4 participants