Refine OAuth scopes for GitLab integration [ON HOLD] #3164
Closed
+172
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
force-pushed
the
at/gitlab-scopes
branch
from
8ba6910 to
8526d54
Compare
Signed-off-by: Alex Tugarev <alex@gitpod.io>
AlexTugarev
force-pushed
the
at/gitlab-scopes
branch
from
8526d54 to
4a8df47
Compare
Signed-off-by: Alex Tugarev <alex@gitpod.io>
1. from the start, we're requesting minimal scopes to read user info (i.e. email)
2. when trying to start a workspace, you need to authorize for reading repositories and reading api
3. when trying to push changes, we request to grant permissions to write to repositories
|
AlexTugarev
changed the title
|
Closing this for now, because it not useable as long as the underlying issue https://gitlab.com/gitlab-org/gitlab/-/issues/321359 isn't solved. We can revise it in one of the coming iterations. |
|
Is there any update on this since https://gitlab.com/gitlab-org/gitlab/-/issues/321359 has been closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1932
ON HOLD
Apparently, it's not possible to push with
write_repositoryscope. While that scope works as intended for personal access tokens on gitlab.com, it does not with OAuth2 tokens. Cf. https://gitlab.com/gitlab-org/gitlab/-/issues/259254#note_506868732Update I filed a bug report per request https://gitlab.com/gitlab-org/gitlab/-/issues/321359
Update I notified the GitLab team about closing this for now, https://gitlab.com/gitlab-org/gitlab/-/issues/259254#note_509064310