[supervisor] active client notifications #16056
Conversation
|
@akosyakov: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
started the job as gitpod-build-ak-ide-no-env-vars.1 because the annotations in the pull request description changed |
|
/werft run with-clean-slate-deployment=true recreate-vm=true 👍 started the job as gitpod-build-ak-ide-no-env-vars.2 |
|
/werft run with-clean-slate-deployment=true recreate-vm=true 👍 started the job as gitpod-build-ak-ide-no-env-vars.3 |
akosyakov
force-pushed
the
ak/ide_no_env_vars
branch
2 times, most recently
from
075fd05 to
157a08f
Compare
|
/werft run 👍 started the job as gitpod-build-ak-ide-no-env-vars.6 |
akosyakov
force-pushed
the
ak/ide_no_env_vars
branch
from
157a08f to
c4fdd56
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I will try a bit another approach with a stack of active client, since it turned out that some clients (JB) don't actually have a way to detect whether they are focused or not. An idea then that latest subscription will win otherwise fail to previous one. It should allow VS Code to grab the focus and then VS Code window is closed fall back to JB window. |
akosyakov
force-pushed
the
ak/ide_no_env_vars
branch
from
c4fdd56 to
3f513bb
Compare
| @@ -998,6 +998,16 @@ func buildChildProcEnv(cfg *Config, envvars []string, runGP bool) []string { | |||
| envs["JAVA_TOOL_OPTIONS"] += fmt.Sprintf(" -Xmx%sm", mem) | |||
| } | |||
|
|
|||
| if envs["EDITOR"] == "" { | |||
There was a problem hiding this comment.
it could break since so far we were forcefully overriding such env vars
|
started the job as gitpod-build-ak-ide-no-env-vars.10 because the annotations in the pull request description changed |
|
started the job as gitpod-build-ak-ide-no-env-vars.11 because the annotations in the pull request description changed |
akosyakov
force-pushed
the
ak/ide_no_env_vars
branch
3 times, most recently
from
92be0f7 to
e4c9fbc
Compare
akosyakov
force-pushed
the
ak/ide_no_env_vars
branch
from
e4c9fbc to
179ab83
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Related Issue(s)
Fixes #8191
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPreview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh