Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test preview #19597

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
Fix list keep show loading
  • Loading branch information
mustard-mh committed Jan 24, 2025
commit dd338513442054b6b0994dad3d4e6ac02f489df6
Original file line number Diff line number Diff line change
@@ -59,7 +59,7 @@ class GitpodRemoteProvider(
Utils.observablePropertiesFactory
)
environmentMap[connectParams.uniqueID] = Pair(workspace, env)
consumer.consumeEnvironments(environmentMap.values.map { it.second }, false)
consumer.consumeEnvironments(environmentMap.values.map { it.second }, true)
}
val joinLinkInfo = publicApi.fetchJoinLink2Info(workspaceId, workspace!!.getIDEUrl())
// TODO(hw): verify if it's working
@@ -75,7 +75,7 @@ class GitpodRemoteProvider(
Utils.coroutineScope.launch {
val workspaces = publicApi.listWorkspaces()
if (workspaces.isEmpty()) {
consumer.consumeEnvironments(emptyList(), false)
consumer.consumeEnvironments(emptyList(), true)
return@launch
}
consumer.consumeEnvironments(workspaces.map {
@@ -91,7 +91,7 @@ class GitpodRemoteProvider(
pendingConnectParams = null
}
env
}, false)
}, true)
}
}