-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more initializer-related info to /insights API #20572
Conversation
6041760
to
7040de0
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
7040de0
to
fb6c6d7
Compare
850049d
to
78c04d6
Compare
@iQQBot Would be awesome if you could help review all the workspace/ws-daemon parts of this PR, with a focus on how these changes could fail/block a workspaces start, which should never be the case. 🙏 |
78c04d6
to
8683749
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, including blocking ones. Continuing with my review in the bg...
components/gitpod-db/src/typeorm/entity/db-workspace-instance-metrics.ts
Show resolved
Hide resolved
….InitializerMetrics Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
…m ws-manager-api into it Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
2b87939
to
d1dd415
Compare
Redeploying the preview... |
Done @filiptronicek
|
Awesome sauce! Looks great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
|
||
// waitForAndReadExtraFiles tries to read the content of the extra files passed to the content initializer, and waits up to 1s to do so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiousity: was waiting the 1s the fix to your problems with the file being empty?
Co-authored-by: Filip Troníček <filip@gitpod.io>
@iQQBot Waiting for your feedback now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, Just curious, why use the fd method to transfer data? Don't we already have file records in filepath.Join(ws.Location, ".gitpod/ready")
? We can also directly read this file.
/unhold |
True! I wanted to to decouple both aspects, and found we already have that |
Description
This PR introduces the following shape on the
ListWorkspaceSessionsApi
:It has basically the same content as the "metrics" shape "ready" in the workspace's
ready
file.Example CSV: gitpod-sessions-supercorp-20250218-20250225.csv
Related Issue(s)
Fixes CLC-1052
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold