Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Fix panix in tests #20638

Merged
merged 1 commit into from
Feb 27, 2025
Merged

[ws-daemon] Fix panix in tests #20638

merged 1 commit into from
Feb 27, 2025

Conversation

geropl
Copy link
Member

@geropl geropl commented Feb 27, 2025

Description

Credit go to cline + Sonnet 3.7 for identifying this bug

prompt:

I got an error when running our controller tests "ginkgo run pkg/controller" in the ws-daemon component, and I don't understand the error.
Please try yourself, try to make sense of the error, and come up with an idea on how to fix the root cause.

Related Issue(s)

Fixes CLC-1185

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Tool: gitpod/catfood.gitpod.cloud
@geropl geropl requested review from a team as code owners February 27, 2025 12:13
@geropl
Copy link
Member Author

geropl commented Feb 27, 2025

/unhold

@filiptronicek
Copy link
Member

Credit go to cline + Sonnet 3.7 for identifying this bug

One day, maybe all bug fix PRs will begin with this line 😄

@geropl
Copy link
Member Author

geropl commented Feb 27, 2025

Credit go to cline + Sonnet 3.7 for identifying this bug

One day, maybe all bug fix PRs will begin with this line 😄

After my experience since yesterday, that day is not too far out. I'd say max 2 months 🙈

@roboquat roboquat merged commit 0cba458 into main Feb 27, 2025
57 of 59 checks passed
@roboquat roboquat deleted the gpl/1185-fix-tests branch February 27, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants