Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] OrganizationService:Fix unpin for pinnedEditorVersions (don't use deepmerge but overwrite if set) #20646

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

geropl
Copy link
Member

@geropl geropl commented Mar 3, 2025

Description

Fix unpin bug discovered in catfood

Related Issue(s)

Fixes CLC-1189

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

…t use deepmerge but overwrite if set)

Tool: gitpod/catfood.gitpod.cloud
@geropl
Copy link
Member Author

geropl commented Mar 3, 2025

/unhold

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked like a charm 🚀

@roboquat roboquat merged commit 23c3e83 into main Mar 3, 2025
46 checks passed
@roboquat roboquat deleted the gpl/1189-unpin-editor branch March 3, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants