Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Install git and linear MCP servers #20647

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

geropl
Copy link
Member

@geropl geropl commented Mar 3, 2025

Description

Where the MCP servers have write access is governed by these env vars one can set in their Gitpod settings:

  • GIT_MCP_WRITE_ACCESS: if true, it enables push
  • LINEAR_MCP_WRITE_ACCESS: if true, it enables adding/updating linear comments and issues

Also, for linear to work, it requires a LINEAR_API_KEY to be present.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@corneliusludmann
Copy link
Contributor

I get the point of the setup of the install script. From a security standpoint, running a shell script from the main branch of a private repo sounds not that great, TBH.

Ideally, we should fork the repo in the gitpod org, IMO. Or at least fetch a specific commit instead of the latest from main. That would work as well, IMO. In both cases, it's need an action on Gitpod side when the script changes.

What do you think, am I being too restrictive here?

@geropl
Copy link
Member Author

geropl commented Mar 4, 2025

From a security standpoint, running a shell script from the main branch of a private repo sounds not that great, TBH.

Totally agree. But as we/I control those, I'd say let's give it a try for now. The only risk I see is that it could be taken as bad precedent.

I see it more as an experiment right now: If this works, we should add the binary to the base image.
And then maybe add the "register with cline" functionality as a subcommand to the binary... ? 🫧

@geropl
Copy link
Member Author

geropl commented Mar 4, 2025

@corneliusludmann But as I'm thinking about it, we can totally "vendor" the scripts here. Let me do that. 💯

Tool: gitpod/catfood.gitpod.cloud
@geropl geropl force-pushed the gpl/install-mcp-servers branch from 14d37e7 to dcccee3 Compare March 4, 2025 08:33
@roboquat roboquat added size/L and removed size/XS labels Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 4, 2025

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@geropl
Copy link
Member Author

geropl commented Mar 4, 2025

/unhold

@roboquat roboquat merged commit 61ecd26 into main Mar 4, 2025
19 checks passed
@roboquat roboquat deleted the gpl/install-mcp-servers branch March 4, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants