Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Fix org-suggested repositories when settings org query is fetching #20649

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

filiptronicek
Copy link
Member

Description

Fixes a regression from #20603 that would let the query give up and be fine with not having any data when org settings weren't loaded yet.

How to test

  1. Sign up for https://ft-fix-orga9fb4e52ec.preview.gitpod-dev.com/workspaces
  2. Observe the repo in the getting started section loads fine

/hold

@geropl
Copy link
Member

geropl commented Mar 4, 2025

@filiptronicek Can you make me admin? Want to test with more repos

@filiptronicek
Copy link
Member Author

@geropl you've got it

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and works nicely! ✔️

@roboquat roboquat merged commit 67b26eb into main Mar 4, 2025
31 of 33 checks passed
@roboquat roboquat deleted the ft/fix-org-suggestion-query branch March 4, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants