Go build fixes #180
Merged
Go build fixes #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows to reference a golangci-lint config in the linter command
by removing the go build deps in the packaging phase
geropl
reviewed
May 24, 2024
geropl
reviewed
May 24, 2024
| @@ -1680,6 +1680,7 @@ func executeCommandsForPackage(buildctx *buildContext, p *Package, wd string, co | |||
| } | |||
|
|
|||
| env := append(os.Environ(), p.Environment...) | |||
| env = append(env, fmt.Sprintf("LEEWAY_WORKSPACE_ROOT=%s", p.C.W.Origin)) | |||
geropl
approved these changes
May 24, 2024
There was a problem hiding this comment.
Fixing the coverage LGTM ✔️
Don't understand this change, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes LEEWAY_WORKSPACE_ROOT available for commands executed during build. This way one can refer to e.g. config files in lint or test commands.
It also fixes a regression for test coverage collection which would affect Go packages referencing other go dependencies, when using Go workspaces.