Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cache and update provenance to v0.2 #198

Merged
merged 10 commits into from
Feb 25, 2025

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 19, 2025

Description

Refactor Cache Implementation and Improve Robustness

Key Changes:

  1. Complete cache architecture refactor

    • Split cache implementation into separate packages
    • Introduce clear interfaces for local and remote caches
    • Add proper abstraction layers for object storage
  2. Caching Improvements

    • Always use transitive dependencies for all package types
    • Ensure consistent caching behavior across package types
    • Improve S3 cache implementation with better error handling and concurrency
  3. Cross-platform Compatibility

    • Add support for macOS by making tar commands platform-aware
    • Remove Linux-specific tar options when running on other platforms
  4. Code Quality Improvements

    • Add comprehensive tests for YAML formatting
    • Enhance git information handling with better error handling
    • Improve error reporting and logging

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 18.83333% with 487 lines in your changes missing coverage. Please review.

Project coverage is 26.27%. Comparing base (3256d17) to head (f909bbc).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   28.84%   26.27%   -2.58%     
==========================================
  Files          21       59      +38     
  Lines        3463     7307    +3844     
==========================================
+ Hits          999     1920     +921     
- Misses       2246     5095    +2849     
- Partials      218      292      +74     

Copy link
Collaborator

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't review in depth, but code LGTM

@aledbf aledbf merged commit 292cb12 into gitpod-io:main Feb 25, 2025
8 checks passed
aledbf added a commit that referenced this pull request Mar 3, 2025
aledbf added a commit that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants