Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kubernetes service monitors #259

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Add Kubernetes service monitors #259

merged 1 commit into from
Aug 15, 2022
+303 −0

Conversation

ArthurSens
Copy link
Contributor

Fixes #252

@ArthurSens
Add Kubernetes service monitors
61bfe8c 
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
@ArthurSens ArthurSens requested a review from a team August 15, 2022 15:20
liam-j-bennett
liam-j-bennett approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@liam-j-bennett liam-j-bennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Minor thing that we could wrap the relabels in a function, but it doesn't save much

@ArthurSens ArthurSens merged commit 709a761 into main Aug 15, 2022
@ArthurSens ArthurSens deleted the arthursens/cli-installer-missing-252 branch August 15, 2022 15:29
@ArthurSens ArthurSens mentioned this pull request Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liam-j-bennett liam-j-bennett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI installer: Missing ServiceMonitor for kubernetes components
2 participants
@ArthurSens @liam-j-bennett