Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring-central/jsonnet: Duplicate certificate resources #294

Closed
ArthurSens opened this issue Aug 31, 2022 · 4 comments
Closed

monitoring-central/jsonnet: Duplicate certificate resources #294

ArthurSens opened this issue Aug 31, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@ArthurSens
Copy link
Contributor

We're currently deploying duplicate certificates for Grafana and VictoriaMetrics. This is a problem especially when they are battling for ownership of their secret and one of those certificates is misconfigured.

Since when creating an Ingress we already create a certificate, we should deploy a separate certificate to it.

@ArthurSens
Copy link
Contributor Author

It is also arguable that we're already migrating monitoring-central to Go as well and we don't need to bother with jsonnet bugs 🤷

@meysholdt
Copy link
Member

@ArthurSens Can you check if we ported the bug to Go?
I assume that we did because our strategy was to achieve YAML parity.

@meysholdt
Copy link
Member

This came up here again.

@ArthurSens
Copy link
Contributor Author

@ArthurSens Can you check if we ported the bug to Go?
I assume that we did because our strategy was to achieve YAML parity.

We never migrated monitoring-central to go, so the bug was not backported 🙂

The bug is not causing any real issues, besides the creation of a resource that does nothing. Since we're moving away from jsonnet for monitoring-central too so we can just leave this undone 😅

@ArthurSens ArthurSens closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2022
Repository owner moved this from 🧊Backlog to ✨Done in 🚚 Security, Infrastructure, and Delivery Team (SID) Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants