Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: release pipeline #332

Merged
merged 6 commits into from
Sep 28, 2022
Merged

fix: release pipeline #332

merged 6 commits into from
Sep 28, 2022
+6 −17

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Sep 24, 2022 •
edited
Loading

fixes #327

Description of changes

  • Added workflow_dispatch so that we can manually run If release pipelines fail sometimes. or in any other case
  • Updated to checkout@v3, not a required change. But things should be updated to LTS.
  • Updated to paulhatch/semantic-version@v5.0.0-alpha which fixes all our pain of weird versioning, not working in forks, etc.
  • Added Path Filters provided by GitHub Actions by default. So it will trigger this release action only when it detects changes on the main branch and installer directory.

@Siddhant-K-code Siddhant-K-code requested a review from a team September 24, 2022 09:03
@Siddhant-K-code Siddhant-K-code mentioned this pull request Sep 24, 2022
Closed
@ArthurSens

This comment was marked as outdated.

Sign in to view
@Siddhant-K-code

This comment was marked as resolved.

Sign in to view
@Siddhant-K-code Siddhant-K-code marked this pull request as draft September 28, 2022 04:26
@Siddhant-K-code

This comment was marked as resolved.

Sign in to view
@Siddhant-K-code Siddhant-K-code marked this pull request as ready for review September 28, 2022 05:19
@Siddhant-K-code Siddhant-K-code added the enhancement New feature or request label Sep 28, 2022
@Siddhant-K-code
Copy link
Member Author

Siddhant-K-code commented Sep 28, 2022 •
edited
Loading

It is working now, updated PR description w/ explaining all the changes. Tested here on my fork:
image

@vulkoingim
Copy link
Contributor

Thank you @Siddhant-K-code for looking into this 🙏

@vulkoingim vulkoingim enabled auto-merge (squash) September 28, 2022 06:13
@vulkoingim vulkoingim disabled auto-merge September 28, 2022 06:21
@vulkoingim vulkoingim merged commit 479ed7e into gitpod-io:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vulkoingim vulkoingim

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken release pipeline
3 participants
@Siddhant-K-code @ArthurSens @vulkoingim