Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] hack/download-installer.sh produces a obs-installer binary that does not work #403

Closed
kylos101 opened this issue Dec 6, 2022 · 1 comment · Fixed by #404
Closed
Labels
bug Something isn't working

Comments

@kylos101
Copy link
Contributor

kylos101 commented Dec 6, 2022

Bug description

From a workspace in the observability repo, we get the below issue, which prevents us from deploying Workspace clusters.

gitpod /workspace/observability (main) $ ./hack/download-installer.sh 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 70.6M  100 70.6M    0     0  19.8M      0  0:00:03  0:00:03 --:--:-- 26.8M
obs-installer
gitpod /workspace/observability (main) $ ./obs-installer 
./obs-installer: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ./obs-installer)
./obs-installer: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by ./obs-installer)

But, if I run a build the same workspace via make -C ./installer/ build , the binary works.

Perhaps something in the Github Action for Release is polluting the release asset?

Suggestion: stop overwriting release assets, too. The 0.0.3 release was created on September 16, but, its release assets appear to get overwritten with each merge to main. 😬

Steps to reproduce

Refer to issue description

Expected behavior

Download a working installer

Example repository

No response

Anything else?

I'm not sure how this impacts the IDE and WebApp teams for their deployments.

For the Workspace deploy, we have to take the following steps:

  1. change workspace-cluster-new job so that
  2. it clones observability repo, but, avoids using hack/download-installer.sh
  3. build the obs-installer manually using make -C ./installer/ build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant