Delete unused jsonnet code #411
Merged
+17
−2,939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
Pothulapati
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409
Monitoring-central is completely written in jsonnet today, but most of monitoring-satellite is managed with our Go installer. We still use the
importfields to import some raw YAML manifests though, which are generated in this same repository using jsonnet. Examples:I've removed all code that is not touched by the examples above.
How to test
After deleting the code, I can run
make generateand make sure that the generated manifests are still the exact same as before