Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused jsonnet code #411

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Delete unused jsonnet code #411

merged 1 commit into from
Dec 15, 2022

Conversation

ArthurSens
Copy link
Contributor

Fixes #409


Monitoring-central is completely written in jsonnet today, but most of monitoring-satellite is managed with our Go installer. We still use the import fields to import some raw YAML manifests though, which are generated in this same repository using jsonnet. Examples:

  • CRDs, using Jsonnet and Jsonnet Bundler to keep them updated with upstream.
  • Grafana, using Jsonnet to transform dashboard JSONs into configmaps
  • HTTP-prober, used by preview environments to establish one of their SLOs.

I've removed all code that is not touched by the examples above.

How to test

After deleting the code, I can run make generate and make sure that the generated manifests are still the exact same as before

Signed-off-by: ArthurSens <arthursens2005@gmail.com>
@ArthurSens ArthurSens requested a review from a team December 12, 2022 13:42
@ArthurSens ArthurSens merged commit 8343d1f into main Dec 15, 2022
@ArthurSens ArthurSens deleted the as/remove-dead-jsonnet branch December 15, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete jsonnet dead code
2 participants