Dep update Github Action fails on Update jsonnet dependencies

[kylos101]

Bug description

Here is a sample job run that is failing

Steps to reproduce

Run the job (I ran it three times and they all failed)

Interestingly, the same steps pass from within a Gitpod workspace.

Expected behavior

It would ideally pass

Example repository

No response

Anything else?

It runs successfully from a Gitpod workspace. 🤔 Perhaps it is related to Github Action runner changes? Ref

[ArthurSens]

Hey @kylos101, the CI fails because it ends with exit code 1 if there is nothing to update. I'm running the script manually inside a workspace and I can see that nothing is being updated, besides the jsonnetfile.lock.json file.

Updating the lock file with nothing else doesn't seem to bring any benefits, hence the intentional failure. Are you sure that the PRs making changes to dashboards were merged before you triggered the CI here?

Is anything that we could do to make the expectations clearer?

[kylos101]

the CI fails because it ends with exit code 1 if there is nothing to update. I'm running the script manually inside a workspace and I can see that nothing is being updated, besides the jsonnetfile.lock.json file.

Can you echo a message on failure, so folks know why the job failed? This way they get feedback from the job, without having to troubleshoot it in a workspace.

Are you sure that the PRs making changes to dashboards were merged before you triggered the CI here?

I recall trying to run this to update SLOs in Pyrra. Perhaps this is the wrong workflow? I was not trying to update a dashboard...doh! What workflow updates Pyrra? Sorry...

[ArthurSens]

the CI fails because it ends with exit code 1 if there is nothing to update. I'm running the script manually inside a workspace and I can see that nothing is being updated, besides the jsonnetfile.lock.json file.

Can you echo a message on failure, so folks know why the job failed? This way they get feedback from the job, without having to troubleshoot it in a workspace.

That's a very good idea! Let me open a PR

Are you sure that the PRs making changes to dashboards were merged before you triggered the CI here?

I recall trying to run this to update SLOs in Pyrra. Perhaps this is the wrong workflow? I was not trying to update a dashboard...doh! What workflow updates Pyrra? Sorry...

SLOs are managed by ArgoCD, e.g. the workspace-slos app. We tried to document that in the architecture page 🙂

Since it is managed by ArgoCD, all you need to update an SLO is commit the change to main. ArgoCD will take care of the rest(it might take a 1~5mins until everything is reconciled)

[kylos101]

Thank you for clarifying how SLOs ship!