Bug: Release download URL fix (#553) #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav3yblaz3
approved these changes
Mar 3, 2025
filiptronicek
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Hi @CodeBreaker444 and thanks a lot for your contribution. Although we no longer use the Dockerfile for building OpenVSCode Server (and use https://github.com/gitpod-io/openvscode-releases/blob/main/.github/workflows/release.yml instead), this looks like a small enough change to ship, if it helps you build it (I unfortunately couldn't get your test command to work).
jeanp413
added a commit
that referenced
this pull request
Mar 7, 2025
…)" This reverts commit 5b3afd2.
jeanp413
added a commit
that referenced
this pull request
Mar 7, 2025
…)" This reverts commit 5b3afd2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While building the docker image from
https://github.com/gitpod-io/openvscode-releases,the github release url for downloading the release of openvscode-server is not properly getting parsed (wrong release name) and throwing404not found error from github. Like in the below image!Related Issue(s)
Fixes #553
How to test
docker build --tag "vscode" --build-arg RELEASE_TAG=v1.88.0 --build-arg RELEASE_TYPE=insiders .Note: You don't need to pass RELEASE_TYPE argument if the release is a stable release.
Documentation