Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in variable name #517

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix typos in variable name #517

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
81c88eb
code web server initial commit
filiptronicek Oct 26, 2021
4843c13
Don't test the Feedback component
filiptronicek Oct 28, 2021
3502944
enable prebuilds for all branches
akosyakov Aug 30, 2022
578aa51
Add example guide for pre-installing vscode extensions with docker in…
axonasif Jan 17, 2023
5109ac4
:lipstick:
jeanp413 Jan 31, 2023
be24c90
Update deprecated example in README
bjrne Apr 18, 2023
1309fce
Patch yarnInstall for openvscode-release
jeanp413 May 4, 2023
d10f0ff
fix: make sure `user-data-dir` command line parameter is customizable
drupol May 17, 2023
db4b217
Fix typos in variable name
gitname Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't test the Feedback component
  • Loading branch information
@filiptronicek @jeanp413
filiptronicek authored and jeanp413 committed Jun 1, 2023
commit 4843c1317047e3392949d3316268fd714a115416
6 changes: 4 additions & 2 deletions test/smoke/src/areas/statusbar/statusbar.test.ts
View file
Original file line number Diff line number Diff line change
@@ -16,9 +16,11 @@ export function setup(logger: Logger) {
it('verifies presence of all default status bar elements', async function () {
const app = this.app as Application;
await app.workbench.statusbar.waitForStatusbarElement(StatusBarElement.BRANCH_STATUS);
if (app.quality !== Quality.Dev && app.quality !== Quality.OSS) {
/*
if (app.quality !== Quality.Dev) {
await app.workbench.statusbar.waitForStatusbarElement(StatusBarElement.FEEDBACK_ICON);
}
*/
await app.workbench.statusbar.waitForStatusbarElement(StatusBarElement.SYNC_STATUS);
await app.workbench.statusbar.waitForStatusbarElement(StatusBarElement.PROBLEMS_STATUS);

@@ -67,7 +69,7 @@ export function setup(logger: Logger) {
await app.workbench.statusbar.waitForEOL('CRLF');
});

it(`verifies that 'Tweet us feedback' pop-up appears when clicking on 'Feedback' icon`, async function () {
it.skip(`verifies that 'Tweet us feedback' pop-up appears when clicking on 'Feedback' icon`, async function () {
const app = this.app as Application;
if (app.quality === Quality.Dev || app.quality === Quality.OSS) {
return this.skip();