Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access: approvers #71861

Closed
Jorropo opened this issue Feb 20, 2025 · 2 comments
Closed

access: approvers #71861

Jorropo opened this issue Feb 20, 2025 · 2 comments
Labels
Access Access request. AccessRequest Issues requesting builder or gomote access. NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@Jorropo
Copy link
Member

Jorropo commented Feb 20, 2025

See https://go.dev/wiki/GerritAccess

Account sean@liao.dev

@seankhliao has been submitting good patches a bit everywhere https://go-review.googlesource.com/q/owner:sean@liao.dev but regularly has to post #contributing channel in go slack to go from « Ready to Submit » to « Merged » state, recent set:
Image
(sorry screenshot I couldn't figure out how to link a slack search)

Note: I've asked Sean's opinion on me opening this issue and the answer was « 🤷 » so here is this issue.

@gopherbot gopherbot added the Access Access request. label Feb 20, 2025
@github-project-automation github-project-automation bot moved this to Incoming in Access Feb 20, 2025
@gabyhelp
Copy link

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gabyhelp gabyhelp added the AccessRequest Issues requesting builder or gomote access. label Feb 20, 2025
@seankhliao seankhliao added this to the Unreleased milestone Feb 20, 2025
@mknyszek mknyszek added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Feb 21, 2025
@prattmic
Copy link
Member

Hi @seankhliao,

Thank you for contributing to the Go project and all of your work throughout the project, including on GitHub. I particularly appreciate all the thought you put into making sure documentation is clear. We've discussed this request on the team and agreed to grant you this access. (Also thanks to @Jorropo for proactively making this access nomination!) I've added you to the approvers group now.

Please be familiar with the rules for voting and submitting changes as described at https://go.dev/wiki/GerritAccess#approving-cls-approvers. If you're unsure or have any questions, please don't hesitate to ask us.

Thank you again for contributing, your help is greatly appreciated!

@github-project-automation github-project-automation bot moved this from Incoming to Reviewed in Access Feb 27, 2025
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Access Access request. AccessRequest Issues requesting builder or gomote access. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Status: Reviewed
Development

No branches or pull requests

7 participants