Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reflect: Value.Seq iteration value types not matching the type of given int types [1.24 backport] #71916

Closed
gopherbot opened this issue Feb 23, 2025 · 2 comments
Closed

reflect: Value.Seq iteration value types not matching the type of given int types [1.24 backport] #71916

gopherbot opened this issue Feb 23, 2025 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.24.1

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #71905 to be considered for backport to the next 1.24 minor release.

@gopherbot Please open backport issues.

The reflect package is using the wrong types when iterating over a sequence of user-defined types.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 23, 2025
@gopherbot gopherbot mentioned this issue Feb 23, 2025
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 23, 2025
@gopherbot gopherbot added this to the Go1.24.1 milestone Feb 23, 2025
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Feb 26, 2025
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 26, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/652895 mentions this issue: [release-branch.go1.24] reflect: let Value.Seq return the iteration value correct type

gopherbot pushed a commit that referenced this issue Feb 26, 2025
@qiulaidongfeng @gopherbot
[release-branch.go1.24] reflect: let Value.Seq return the iteration v…
7f375e2 
…alue correct type

Fixes #71916
For #71905

Change-Id: I50a418f8552e071c6e5011af5b9accc7d41548d0
Reviewed-on: https://go-review.googlesource.com/c/go/+/651855
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
(cherry picked from commit 194696f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/652895
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 652895 (commit 7f375e2) to release-branch.go1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.24.1
Development

No branches or pull requests
2 participants
@prattmic @gopherbot