Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/cgo: does not build with -Wdeclaration-after-statement [1.23 backport] #71962

Closed
gopherbot opened this issue Feb 26, 2025 · 3 comments
Closed

runtime/cgo: does not build with -Wdeclaration-after-statement [1.23 backport] #71962

gopherbot opened this issue Feb 26, 2025 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.23.7

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #71961 to be considered for backport to the next 1.23 minor release.

@gopherbot Please open backport issues.

This breaks the SWIG CI build.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 26, 2025
@gopherbot gopherbot mentioned this issue Feb 26, 2025
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 26, 2025
@gopherbot gopherbot added this to the Go1.23.7 milestone Feb 26, 2025
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Feb 26, 2025
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 26, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/652935 mentions this issue: [release-branch.go1.23] runtime/cgo: avoid errors from -Wdeclaration-after-statement

gopherbot pushed a commit that referenced this issue Feb 26, 2025
@ianlancetaylor @gopherbot
[release-branch.go1.23] runtime/cgo: avoid errors from -Wdeclaration-…
9facf1f 
…after-statement

It's used by the SWIG CI build, at least, and it's an easy fix.

[The change in x_cgo_sys_thread_create is gone, as that function was
already compliant in 1.23.]

Fixes #71962
For #71961

Change-Id: Id21071a5aef216b35ecf0e9cd3e05d08972d92fe
Reviewed-on: https://go-review.googlesource.com/c/go/+/652181
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
(cherry picked from commit 76c7028)
Reviewed-on: https://go-review.googlesource.com/c/go/+/652935
Reviewed-by: Michael Knyszek <mknyszek@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 652935 (commit 9facf1f) to release-branch.go1.23.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/653136 mentions this issue: [release-branch.go1.23] runtime/cgo: avoid errors from -Wdeclaration-after-statement

gopherbot pushed a commit that referenced this issue Feb 26, 2025
@ianlancetaylor @gopherbot
[release-branch.go1.23] runtime/cgo: avoid errors from -Wdeclaration-…
e477283 
…after-statement

CL 652181 accidentally missed this iPhone only code.

For #71961
For #71962

Change-Id: I567f8bb38958907442e69494da330d5199d11f54
Reviewed-on: https://go-review.googlesource.com/c/go/+/653136
Reviewed-by: Michael Pratt <mpratt@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.23.7
Development

No branches or pull requests
2 participants
@prattmic @gopherbot